Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RND-86: Upgrade LS to use label-studio-sdk=1.0 #5961

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Jun 10, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

sentry-io bot commented Jun 10, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/core/utils/common.py

Function Unhandled Issue
collect_versions OSError: [Errno 28] No space left on device /.env
Event Count: 1
collect_versions OSError: [Errno 28] No space left on device /vers...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the fix label Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 0c0dc47
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6666faba4db2cb0008491e8a

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 0c0dc47
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6666fabae1ad460008be0ed4

pyproject.toml Outdated Show resolved Hide resolved
@farioas farioas requested a review from a team as a code owner June 10, 2024 11:25
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.06%. Comparing base (f4c3185) to head (0c0dc47).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5961   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files          162      162           
  Lines        13469    13469           
========================================
  Hits         10245    10245           
  Misses        3224     3224           
Flag Coverage Δ
pytests 76.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niklub niklub merged commit 300bec1 into develop Jun 10, 2024
39 checks passed
@nikitabelonogov nikitabelonogov deleted the fb-RND-86 branch June 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants