Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DOC-220: Remove FF references from docs #5984

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Conversation

caitlinwheeless
Copy link
Contributor

@caitlinwheeless caitlinwheeless commented Jun 13, 2024

Removing feature flag references from docs.

Affects

  • Community docs
  • Enterprise docs

@github-actions github-actions bot added the docs label Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 72a6a8a
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/666b411c7568cc000816822c
😎 Deploy Preview https://deploy-preview-5984--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 72a6a8a
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/666b411c4250f100083f4c94
😎 Deploy Preview https://deploy-preview-5984--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@luarmr luarmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think it's very odd to just remove all parameters somehow connected to feature flags. The main idea of feature flags is that they will be enabled at some point (as soon as possible actually). So most of this params most probably are available for everyone and we really need them in docs. Let's discuss this.

@hlomzik hlomzik marked this pull request as draft June 13, 2024 17:34
@hlomzik hlomzik marked this pull request as ready for review June 13, 2024 17:35
@farioas
Copy link
Member

farioas commented Jun 13, 2024

/git merge develop

Workflow run
Successfully merged: 12 files changed, 68 insertions(+), 29 deletions(-)

@caitlinwheeless caitlinwheeless merged commit 5de6080 into develop Jun 13, 2024
30 checks passed
@caitlinwheeless caitlinwheeless deleted the docs/ff-removal branch June 13, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants