Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-453: Fix annotation and draft being requested at the same time #6005

Merged
merged 9 commits into from
Jun 26, 2024

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Jun 17, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

The auto-save feature for annotations currently triggers a draft save request 5 seconds after annotation begins. In our Selenium tests, this timing issue sometimes causes both the draft and annotation submission requests to be sent simultaneously. This can result in duplicated draft and annotation being displayed in the quick view for users.

What does this fix?

This change implements a queue system to manage the timing of draft saves and annotation submissions. The annotation submission now waits until the draft save request is completed before proceeding. This ensures that the backend processes these requests sequentially, preventing duplication issues.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8256b47
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/667b2ac3749a5d0008a0511a

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8256b47
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/667b2ac3a46aaa000848b727

@github-actions github-actions bot added the fix label Jun 17, 2024
@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jun 18, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 docs/source/tutorials/screenshot.png

@niklub
Copy link
Collaborator

niklub commented Jun 24, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 label_studio/ml_models/migrations/0008_modelrun_total_tasks.py

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jun 25, 2024

/docker build

Workflow run
Docker image was pushed with the tag 20240625.141230-fb-leap-453-b61384cd2

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jun 25, 2024

/docker build

Workflow run
Docker image was pushed with the tag 20240625.162612-fb-leap-453-54c691515

@juliosgarbi juliosgarbi merged commit 88a45a7 into develop Jun 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants