Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change the audio url for tests to a local one to avoid connection issues which cause test flakes #6009

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Jun 18, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Currently we have seen test flakes occur in the audio related tests. The failure is always the same, it is a failed to fetch the audio url error which is thrown by various tests which are using an s3 url. To stabilize and remove this from being a possible test failure I moved the tests to use a locally sourced version of the same file.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Tests which include Audio tag.

@github-actions github-actions bot added the chore label Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8b35cad
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6671bf6b7c907f0008c4fd43

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8b35cad
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6671bf6b87ec520008b8afe2

@bmartel bmartel enabled auto-merge (squash) June 18, 2024 17:44
@bmartel bmartel merged commit ef63bed into develop Jun 18, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants