Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Add wait check for PER workspaces #5572

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[R] Add wait check for PER workspaces #5572

merged 1 commit into from
Aug 28, 2024

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

 === RUN   TestAccIBMPINetworkbasic
 --- PASS: TestAccIBMPINetworkbasic (63.96s)
PASS

=== RUN   TestAccIBMPINetworkGatewaybasic
--- PASS: TestAccIBMPINetworkGatewaybasic (109.09s)
PASS

Add check for PER enable workspace in the network creation, otherwise that will end up in error state if PER are still being configure when a request is sent.

@michaelkad michaelkad added enhancement service/Power Systems Issues related to Power Systems labels Aug 21, 2024
yussufsh
yussufsh reviewed Aug 24, 2024
View reviewed changes
ibm/service/power/resource_ibm_pi_network.go
if err != nil {
return diag.FromErr(err)
}
if wsData.Capabilities[PER] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if Capabilities PER does not exist? Will it always be a boolean or could be empty?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yussufsh this capability will always be set to False if a workspace is not PER enabled.

@yussufsh yussufsh merged commit 982061f into master Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@ismirlia ismirlia Awaiting requested review from ismirlia

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

Assignees
No one assigned
Labels
enhancement service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkad @yussufsh