Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flag to disable version check #42

Closed
aw-was-here opened this issue Dec 24, 2021 · 0 comments · Fixed by #139
Closed

[BUG] Flag to disable version check #42

aw-was-here opened this issue Dec 24, 2021 · 0 comments · Fixed by #139

Comments

@aw-was-here
Copy link

Describe the bug

There should be a way to disable the version check.

To Reproduce
Steps to reproduce the behavior:

  1. Build a container with a tested version of detect-secrets that you do not want to upgrade because you want reproducible builds.
  2. Wait for IBM to roll the version forward.
  3. Get a message that you don't want to see.

Expected behavior
detect-secrets --disable-version-check (or whatever) does not print the message.

Screenshots
NA, it is pretty obvious.

Impact

I would like reproducible builds. I do not care if it is out of date because I want that version. This version check may be a blocker for including it as part of the larger Apache Yetus project build. ☹️

Additional context:
NA
dnwe added a commit to dnwe/detect-secrets that referenced this issue Nov 22, 2023
@dnwe
feat: add --no-version-check cmdline option
2513f61 
Skip the remote version check (to s3) if the user passes
`--no-version-check` as a cmdline option.

Fixes IBM#42

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe mentioned this issue Nov 22, 2023
Merged
dnwe added a commit to dnwe/detect-secrets that referenced this issue Nov 22, 2023
@dnwe
feat: add --no-version-check cmdline option
6066b50 
Skip the remote version check (to s3) if the user passes
`--no-version-check` as a cmdline option.

Fixes IBM#42

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --no-version-check cmdline option dnwe/detect-secrets
1 participant
@aw-was-here