Pin requests (new version is broken), and update urllib3 in requirements-dev #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts-dev Signed-off-by: Victoria Miltcheva <12804086+victoria-miltcheva@users.noreply.github.com>
victoria-miltcheva
force-pushed
the
peg-requests-dependency
branch
from
b322b3c
to
2f130a5
Compare
Signed-off-by: Victoria Miltcheva <12804086+victoria-miltcheva@users.noreply.github.com>
williamsbritt
approved these changes
May 4, 2023
victoria-miltcheva
changed the title
|
CVE-2023-32681 is getting flagged as requests is stuck under the patched version (
Is there more information somewhere related to this statement to be able to re-test if is still the case with the new 2.31.0? edit: #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
requestsv2.30.0package appears to be broken, I've pinnedrequeststo the previous version. I've also bumped the version ofurllib3used for local development to the version which comes withrequestsv2.29.0.