Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1032 trace explorer show evaluations of lambda nodes #1034

Conversation

mgronover
Copy link
Collaborator

addresses issue: #1032

Values of nodes in lambda expression are used decorate the corresponding editor nodes.

@mgronover mgronover requested review from alexanderpann and removed request for wsafonov and arimer August 13, 2024 07:23
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small remark:

InterpreterUserObjectDecorator#getMappedNode already assumes a LambdaExpression, so the method should probably only be used if the node contains an lambda expression or be renamed.

@mgronover
Copy link
Collaborator Author

LGTM, one small remark:

InterpreterUserObjectDecorator#getMappedNode already assumes a LambdaExpression, so the method should probably only be used if the node contains an lambda expression or be renamed.

It should be callable with any recorded node and checks if that recorded node is a descendent of a lambda expression (i. e. has an anchester that is a lmabda expression). If that is true the lambda expression may contain a user object, a map associating nodes contained in a model to nodes evaluated and contained in that trace.
So it gets the node that is contained in the model for any node that is recorded (these might be the same if no lambda expression is used).

@mgronover mgronover merged commit 30ae1a8 into maintenance/mps20222 Aug 13, 2024
1 check passed
@mgronover mgronover deleted the bugfix/1032-TraceExplorer-show-evaluations-of-lambda-nodes branch August 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants