Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr.genjava.data:DataTableLookup: fixed java generation column index #939

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

arimer
Copy link
Member

@arimer arimer commented Apr 29, 2024

porting changes from #912

Fixed column index to reflect the correct position of the column, previously it was always zero due to indexing the wrong node.
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine but the generator and interpreter implementation look quite different to me in general. Why is DataTable#defaultLookupColumn only supported by the interpreter?

alexanderpann

This comment was marked as duplicate.

@arimer
Copy link
Member Author

arimer commented Apr 30, 2024

Why is DataTable#defaultLookupColumn only supported by the interpreter?

Unfortunatelly I don't know why :/

@arimer arimer merged commit 5a3c3e9 into maintenance/mps20213 Apr 30, 2024
1 check passed
@arimer arimer deleted the bugfix/data-table-lookup_port branch April 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants