Skip to content

Commit

Permalink
Merge #2531
Browse files Browse the repository at this point in the history
2531: fix(reports): add title attribute r=jniles a=jniles

This commit adds the HTML title attribute to select reports that run the risk of missing elements due to small screen sizes.  This title will only appear when the mouse hovers over the text, specifically on the report HTML preview.

Closes #2526.
  • Loading branch information
bors[bot] committed Feb 8, 2018
2 parents b5d88c4 + 6f56f3a commit 3820595
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
{{#equal this.type_id ../TITLE_ID}}
<tr>
<td class="text-right"><strong>{{ this.number }}</strong></td>
<td class="text-left">
<td class="text-left" title="{{this.label}}">
<strong style="margin-left: {{indentAccount this.depth}};">
{{#if this.locked}}
<i class="fa fa-lock"></i>
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/finance/reports/cash/report.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
<tbody>
{{#each rows}}
<tr>
<td>{{reference}}</td>
<td title="{{reference}}">{{reference}}</td>
<td class="text-right">{{date date}}</td>
<td>{{debtor_name}}</td>
<td title="{{debtor_name}}">{{debtor_name}}</td>
<td class="text-right">{{currency amount currency_id}}</td>
<td>{{cashbox_label}}</td>
<td>{{display_name}}</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
{{#each transactions}}
<tr>
<td>{{date this.trans_date}}</td>
<td class="text-right">{{this.document}}</td>
<td class="text-right">{{this.trans_id}}</td>
<td style="max-width : 200px; white-space : nowrap; overflow : hidden; text-overflow : ellipsis;">{{this.description}}</td>
<td class="text-right" title="{{this.document}}">{{this.document}}</td>
<td class="text-right" title="{{this.trans_id}}">{{this.trans_id}}</td>
<td style="max-width : 200px; white-space : nowrap; overflow : hidden; text-overflow : ellipsis;" title="{{this.description}}">{{this.description}}</td>
<td class="text-right {{#if this.credit}}text-danger{{/if}}">
{{#if this.credit}}
({{currency this.credit ../metadata.enterprise.currency_id}})
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/finance/reports/invoices/report.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
<tbody>
{{#each rows}}
<tr>
<td>{{reference}}</td>
<td title="{{reference}}">{{reference}}</td>
<td class="text-right">{{date date}}</td>
<td>{{patientName}}</td>
<td title="{{patientName}}">{{patientName}}</td>
<td class="text-right">{{currency cost currency_id}}</td>
<td>{{serviceName}}</td>
<td>{{display_name}}</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
{{#each transactions}}
<tr>
<td>{{date this.trans_date}}</td>
<td>{{this.trans_id}}</td>
<td>{{this.document_reference}}</td>
<td style="max-width : 200px; white-space : nowrap; overflow : hidden; text-overflow : ellipsis;">{{this.description}}</td>
<td title="{{this.trans_id}}">{{this.trans_id}}</td>
<td title="{{this.document_reference}}">{{this.document_reference}}</td>
<td style="max-width : 200px; white-space : nowrap; overflow : hidden; text-overflow : ellipsis;" title="{{this.description}}">{{this.description}}</td>
<td class="text-right">
{{#if ../useOriginalTransactionCurrency}}
{{#if this.debit}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<tr>
<td>{{voucher.reference}}</td>
<td>{{date voucher.date}}</td>
<td>{{voucher.description}}</td>
<td title="{{voucher.description}}">{{voucher.description}}</td>
<td class="text-right">{{currency voucher.amount voucher.currency_id}}</td>
<td>{{voucher.display_name}}</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/inventory/reports/items.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
<tbody>
{{#each rows}}
<tr>
<td>{{code}}</td>
<td>{{label}}</td>
<td title="{{code}}">{{code}}</td>
<td title="{{label}}">{{label}}</td>
<td class="text-right">{{currency price ../metadata.enterprise.currency_id }}</td>
<td>{{unit}}</td>
<td>{{type}}</td>
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/medical/reports/registrations.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
<tbody>
{{#each patients}}
<tr>
<td>{{this.reference}}</td>
<td title="{{this.reference}}">{{this.reference}}</td>
<td>{{this.hospital_no}}</td>
<td>{{this.display_name}}</td>
<td title="{{this.display_name}}">{{this.display_name}}</td>
<td>{{this.sex}}</td>
<td>{{this.age}} ({{date this.dob}})</td>
<td>{{this.originVillageName}}</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
{{#each employees}}
<tr>
<td>{{this.code}}</td>
<td>{{this.display_name}}</td>
<td title="{{this.display_name}}">{{this.display_name}}</td>
<td>{{this.sex}}</td>
<td>{{this.age}} ({{date this.dob}})</td>
<td>{{this.code_grade}}</td>
Expand Down

0 comments on commit 3820595

Please sign in to comment.