Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting all unused Service #341

Merged
merged 3 commits into from
Apr 21, 2016

Conversation

lomamech
Copy link
Contributor

  • Deleting all old unused Service of Bhima 1.x
  • Fix error arround Test E2E for simple voucher
  • Deleting some old units who is not used in Bhima 2.x

@sfount @jniles

@jniles
Copy link
Collaborator

jniles commented Apr 20, 2016

@lomamech, merci pour une grande effort. Je vais le tester demain matin, et si ca passe, je vais le melanger.

@jniles
Copy link
Collaborator

jniles commented Apr 21, 2016

@lomamech, il y a des erreurs sur ta branch, relatif a locations.js.

protractor.log.txt

Deleting all old unused Service of Bhima 1.x
Fix error arround Test E2E for simple voucher
Deleting some old units who is not used in Bhima 2.x
Removing tables for Snis except mod_snis_zs (For health areas)
Removal of existing paths in the root file on tables SNIS that were deleted
Updating the file server/controllers/medical/snis.js
@lomamech
Copy link
Contributor Author

Fix error error arround locations Updating (Country, Province, sector, village)

@jniles

@@ -517,9 +513,9 @@ exports.update.province = function updateProvince(req, res, next) {

var data = convert(req.body);

db.exec(sql, [data, uid])
db.exec(sql, [data, req.params.uuid])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really helpful! Thanks!

@jniles
Copy link
Collaborator

jniles commented Apr 21, 2016

LTGM. All tests pass!

@jniles jniles merged commit 41ab28c into IMA-WorldHealth:master Apr 21, 2016
@lomamech lomamech deleted the deleteUnUsedService branch May 15, 2017 12:21
bors bot added a commit that referenced this pull request Jan 21, 2019
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.122.3</summary>

<h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this pull request Jan 21, 2019
3550: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.1` to `1.122.3`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.122.3</summary>

<h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.2...v1.122.3">1.122.3</a> (2019-01-21)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>bump php plugin to better support file paths (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35">319cf35</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b07600cf7d935bb9a022fba1a8c8486db051878"><code>6b07600</code></a> <code>Merge pull request #337 from snyk/fix/php-plugin-bump</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/319cf35833b4bb24e6070cdec611280dd8c602e9"><code>319cf35</code></a> <code>fix: bump php plugin to better support file paths</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f773c773e44deac8655006f19bafe9e4825fb6d7"><code>f773c77</code></a> <code>Merge pull request #338 from snyk/fix/bump-docker-plugin</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b4ba234106ac0f0bf37ea9408071c95b12dd5d63"><code>b4ba234</code></a> <code>Merge pull request #341 from snyk/test/revert-a-fixture-change</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bbfd7002aed081b4c4018c4f2743a11329c93f9a"><code>bbfd700</code></a> <code>test: remove a fixture change done in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401225818" data-permission-text="Issue title is private" data-url="snyk/cli#340" data-hovercard-type="pull_request" data-hovercard-url="/snyk/cli/pull/340/hovercard" href="https://urls.greenkeeper.io/snyk/snyk/pull/340">#340</a></code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3667dcdc5b074f04d4ba5184a9293a0e97691bd2"><code>3667dcd</code></a> <code>fix: bump docker plugin</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/567e3b31d8dd3a67755ed726e0da21efcad91ba8...6b07600cf7d935bb9a022fba1a8c8486db051878">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants