Patient document preview #452
Conversation
| bindings: { | ||
| onSearchComplete : '&', // bind callback | ||
| enablePatientDetails : '<', // bind boolean (true|false) : Enable patient details option | ||
| enableOptionBar : '<', // bind boolean (true|false) : Enable option for add, display list or display thumbnail in a bar |
There was a problem hiding this comment.
Can most of these options be bound as attributes @ to avoid too many $watch() statements? Or must they be dynamic?
|
@mbayopanda, I've completed an initial review. The behavior is excellent! The decision to use a component instead of a There are some minor code issues, but overall, this was a well designed, well executed module. Well done! I'll give you a chance to review the comments and then merge once the fixes land or discussion finishes. All failing tests can be fixed with a |
|
@mbayopanda, let me know when you are ready for a second review. |
mbayopanda
force-pushed
the
patient_document_preview
branch
from
7254bbf
to
0886eac
Compare
|
@jniles could you review this PR again... |
| @@ -404,6 +405,12 @@ | |||
| "SERVICE" : "Service", | |||
| "SET_DATE" : "Changer la Date", | |||
| "SEX" : "Sexe", | |||
| "SIZE_BYTES" : "Octets", | |||
|
Everything LGTM! |
major component implementation Use of documents component in the patient module Fix and enhancement of patient document component and module
This PR add :
And in this PR we update the patient_document table by adding mimetype, size, user_id columns