Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ui grid filtering #507

Merged
merged 3 commits into from
Jun 21, 2016
Merged

Feature: ui grid filtering #507

merged 3 commits into from
Jun 21, 2016

Commits on Jun 21, 2016

  1. refactor(filters): improve Patient Registry filter 

    This commit refactors the Patient Registry filters to automatically
template into the registration page nice-looking filters.

Features landing in this commit:
 1. Filters are now cancellable, which refreshes the grid with the
 remaining filters.
 2. Filters are automatically templated into the PDF report generated by
 clicking the `print()` button on the registry page.
 3. "Clear All Filters" button clears all filters on the grid and
 refreshes the grid's data via an HTTP request
 4. Filters are cached so that a page refresh does not clear the
 filters.
 5. The filter form UI has drastically improved, allows start and end
 dates to be laid out side by side.

There are some future directions left to do after the commit.
 1. Improve rendering of filters in PDF reports.  The dates are not
 properly templated in, now do the values have much meaning.
 2. Rename the `bhFiltersApplied` directive to something a bit more
 descriptive of it's form and function.  Something like `bhFilterBar` or
 similar.
 3. Implement filtering tests as unit tests for search modal.
    @jniles
    jniles committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    3f7bc03 View commit details
    Browse the repository at this point in the history

  2. feat(filters): improve filter ui rendering 

    This commit improves the filters ui again by introducing the following
upgrades:
 1. The server uses `moment` to parse dates in the date filters.  The
 code on the server for rendering the filters is very similar to the
 clientside codebase, which is unavoidable.  There might be an
 optimisation down the road to reduce this replication, but I think this
 is acceptable for now.

 2. The filters are now passed into the filter form and preset there.
 That way, when you go to filter a second time, all the data is
 preserved.

 3. A weird bug with caching filters was fixed.  The detailed flag no
 longer shows up as a potential filter, and refreshing the page after
 printing no longer breaks the browser.

 4. The date rendering has been improved in the handlebar's date helper
 function.  If an invalid date occurs, it will simply render the empty
 string.

 5. The `$uibModal` handler now implements the behavior described in
 #506.

Closes #492.  Closes #336.
    @jniles
    jniles committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    45f2f44 View commit details
    Browse the repository at this point in the history

  3. docs(bhFiltersApplied): improve directive docs 

    This commit adds doc comments to the bhFiltersApplied directive for
better readability and developer productivity in the future.
    @jniles
    jniles committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    aab37ab View commit details
    Browse the repository at this point in the history