Voucher Registry Module #561

mbayopanda · 2016-07-06T11:42:32Z

This PR :

Add the voucher registry module
-- Viewing list of all vouchers made
-- Search vouchers by date interval
-- Print PDF receipt for vouchers
-- Print PDF report for vouchers made

…into transfert_type

mbayopanda · 2016-07-06T11:45:50Z

@jniles could you review this PR please...

jniles · 2016-07-06T13:38:57Z

client/src/js/app.js

@@ -218,6 +218,11 @@ function bhimaConfig($stateProvider, $urlRouterProvider, $urlMatcherFactoryProvi
    controller: 'ComplexJournalVoucherController as ComplexVoucherCtrl',
    templateUrl: 'partials/vouchers/complex.html'
  })
+  .state('vouchersRecords', {
+    url : '/vouchers/records',


This url should just be /vouchers. For reference:

/invoices -> invoice registry

/patients -> patient registry

@sfount proposed this model in #391.

jniles · 2016-07-09T11:00:54Z

client/src/css/structure.css

@@ -185,6 +185,8 @@
  border: none;
  max-height : 42px;
  border-bottom : 1px solid #ccc;
+  min-height: 35px;
+  padding-top: 7px;


Why was this padding-top necessary? It seems very ... custom.

Maybe the flex-util need some fixation, the padding-top: 7px is necessary to avoid to have something like this :

The content of the util bar is so closed to the top of the flex-util bar, the padding-top: 7px; is not so good, maybe i can use line-height: 35px or other things to center the content in the util bar.

All proposals are welcome

jniles · 2016-07-09T17:30:38Z

server/controllers/finance/vouchers.js

@@ -198,13 +242,90 @@ function report(req, res, next) {
 * @param {null|object} query The req.query object, retunrs list of voucher according the query,
 * @return promise
 */
-function getVouchers(uuid) {
+function getVouchers(uuid, request) {


This query is very complex, and could be refactored. However, it is clean enough to be merged into master. Thanks for the documentation comments and the clear variable names!

jniles · 2016-07-09T17:31:11Z

Tests pass and the code is clean. Good work!

…into transfert_type

3212: Update commitizen to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [commitizen](https://github.com/commitizen/cz-cli) was updated from `2.10.1` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v3.0.0</summary> <p><a name"3.0.0"></p> <h2>3.0.0 (2018-10-01)</h2> <h4>Bug Fixes</h4> <ul> <li>resolve linux build issues, add git exit code 128 warning (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c">c3764c8c</a>)</li> <li><strong>deps:</strong> <ul> <li>update dependency glob to v7.1.2 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327664" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#506" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/506">#506</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa824960">aa824960</a>)</li> <li>update dependency lodash to v4.17.10 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326338773" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#507" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/507">#507</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda9435">4bda9435</a>)</li> <li>update dependency find-root to v1.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327598" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#505" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/505">#505</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a">67a4e16a</a>)</li> <li>update dependency dedent to v0.7.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314146" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#504" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/504">#504</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a21b674f">a21b674f</a>)</li> <li>update dependency cz-conventional-changelog to v2.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314071" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#503" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/503">#503</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/43d54de1">43d54de1</a>)</li> </ul> </li> <li><strong>package:</strong> Remove opencollective post-install hook (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="356422024" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#561" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/561">#561</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d">a70c234d</a>)</li> </ul> <h4>Features</h4> <ul> <li>Drop support for Node.js <6.x, update dependencies (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="361350875" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#566" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/566">#566</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</li> <li>support initialization with yarn. (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="349367370" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#549" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/549">#549</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154">d5652154</a>, closes <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>, <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>)</li> </ul> <h4>Breaking Changes</h4> <ul> <li>Older versions of Node.js are no longer supported</li> </ul> <p>Includes most updates with the exception of semantic-release which breaks on windows. To be investigated in a later release.<br> (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</p> </details> <details> <summary>Commits</summary> <p>The new version differs by 23 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b06dbdf41af322dab06f83bfddd69149b"><code>a70c063</code></a> <code>feat: Drop support for Node.js <6.x, update dependencies (#566)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/0d76887b7853f673949cf7aee04653b90b4dda7b"><code>0d76887</code></a> <code>chore: remove sign from windows build</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/1546df4856dc8c4aa781e9e0ea755613647642ca"><code>1546df4</code></a> <code>chore: assume yarn in tests</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c1d2b05597a6c604c13b6a11731c47281"><code>c3764c8</code></a> <code>fix: resolve linux build issues, add git exit code 128 warning</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f1150c83a62048831fe6d94836f52242fdc9831e"><code>f1150c8</code></a> <code>chore: Create jobs build yml</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f0595edca921b68913e2ce2ca1bbad75abe71515"><code>f0595ed</code></a> <code>chore: add azure jobs</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4693079d0400ad1a914af86c6027f83d18cde74d"><code>4693079</code></a> <code>chore: Set up CI with Azure Pipelines</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154fa1bb41c1b1c84f20c620ee64ca32c78"><code>d565215</code></a> <code>feat: support initialization with yarn. fixes #527 (#549)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d8471af147cc9f7d9d090b6ba2192eb17"><code>a70c234</code></a> <code>fix(package): Remove opencollective post-install hook (#561)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5b8bc587770e4a7efd6a36962abaa0425931181"><code>d5b8bc5</code></a> <code>docs(readme): add npx use examples (#532)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d103b10f56121a8617ac9ac882338338417b0947"><code>d103b10</code></a> <code>chore(ci): test on Node.js 10.x (#531)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/41a921b002d1627cfedd4bb5745a27d8a47a5dfe"><code>41a921b</code></a> <code>BREAKING CHANGE: Remove Node 0.12 support (#524)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa8249605d45c1e95f57be7c832321212b0e8d1c"><code>aa82496</code></a> <code>fix(deps): update dependency glob to v7.1.2 (#506)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda94350625e54ca862cd143432de1912caea27"><code>4bda943</code></a> <code>fix(deps): update dependency lodash to v4.17.10 (#507)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a88c7925f3199996002ba8da37e420cff"><code>67a4e16</code></a> <code>fix(deps): update dependency find-root to v1.1.0 (#505)</code></li> </ul> <p>There are 23 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/commitizen/cz-cli/compare/5838ce007c1af2e71ef6ae68efce7682d59e9061...a70c063b06dbdf41af322dab06f83bfddd69149b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>

mbayopanda added 9 commits June 27, 2016 09:54

Transfer type for simple voucher

d936e22

Merge branch 'master' of https://github.com/IMA-WorldHealth/bhima-2.X …

ac888fb

…into transfert_type

Voucher report implementation

c00b046

Fix mergin conflicts

5baf6fa

Fix and enhancement according the review

5b86593

Fix mergin conflicts

92458cd

Fix i18n ortograpn

c0046b5

Fix es6 standards for old version of node

f647b0b

Update and Fix mergin conflicts

d54aa5a

jniles reviewed Jul 6, 2016
View reviewed changes

jniles reviewed Jul 9, 2016
View reviewed changes

mbayopanda force-pushed the transfert_type branch 2 times, most recently from 1393d35 to 20adb89 Compare July 9, 2016 13:27

jniles reviewed Jul 9, 2016
View reviewed changes

jniles merged commit a764aff into IMA-WorldHealth:master Jul 9, 2016

mbayopanda added 2 commits July 9, 2016 13:13

Fix and enhancement of codees

18f3749

Merge branch 'master' of https://github.com/IMA-WorldHealth/bhima-2.X …

20adb89

…into transfert_type

jniles mentioned this pull request Jul 11, 2016

Use of 'origin_id' in Voucher table as a reference to the voucher type #562

Closed

mbayopanda deleted the transfert_type branch September 14, 2016 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voucher Registry Module #561

Voucher Registry Module #561

mbayopanda commented Jul 6, 2016

mbayopanda commented Jul 6, 2016

jniles Jul 6, 2016

jniles Jul 9, 2016

mbayopanda Jul 9, 2016 •

edited

Loading

jniles Jul 9, 2016

jniles commented Jul 9, 2016

Voucher Registry Module #561

Voucher Registry Module #561

Conversation

mbayopanda commented Jul 6, 2016

mbayopanda commented Jul 6, 2016

jniles Jul 6, 2016

Choose a reason for hiding this comment

jniles Jul 9, 2016

Choose a reason for hiding this comment

mbayopanda Jul 9, 2016 • edited Loading

Choose a reason for hiding this comment

jniles Jul 9, 2016

Choose a reason for hiding this comment

jniles commented Jul 9, 2016

mbayopanda Jul 9, 2016 •

edited

Loading