remove "implements Serializable" from ModuleFactory, PackageFactory an… #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d DefaultCoreFactory
|
We have an "unused import" CI error. I guess it's too hard to quickly fix the sniper mode for this, could you remove it manually? |
|
API changes: 3 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:7.1.0-20180705.100045-7 / New API: fr.inria.gforge.spoon:spoon-core:jar:7.1.0-SNAPSHOT
|
|
LGTM @pvojtechovsky if you prefer this one over #2169, merge? |
|
@ashutosh1598 thank you for that cleaning 👍 and for experimenting with Sniper mode. I have nearly no time this week so it needs longer until the known problems of Sniper mode are fixed ... be patient please. |
tdurieux
reviewed
Jul 5, 2018
|
|
||
| /** | ||
| * The {@link CtPackage} sub-factory. | ||
| */ | ||
| public class PackageFactory extends SubFactory implements Serializable { | ||
| public class PackageFactory extends SubFactory { | ||
| private static final long serialVersionUID = 1L; |
There was a problem hiding this comment.
serialVersionUID should be removed at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d DefaultCoreFactory. This PR is alternative to #2169. Instead of adding a constructor to SubFactory, it makes these subclasses unserializable.
Apart from these 3 bugs, it also removes (DOESN'T)two bugs of Sonar Rule 1948, since ModuleFactory will no longer be Serializable.
Edit : It won't remove those two bugs of rule 1948 because these fields are in a nested class which is also Serializable.