Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move Ifs.java to testclasses in control #2182

Merged
merged 3 commits into from
Jul 12, 2018
Merged

refactor: move Ifs.java to testclasses in control #2182

merged 3 commits into from
Jul 12, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Jul 7, 2018 •
edited
Loading

I am ready to merge.

@zielint0 zielint0 mentioned this pull request Jul 7, 2018
Open
@zielint0 zielint0 changed the title refactor: move Ifs.java to testclasses refactor: move Ifs.java to testclasses in control Jul 7, 2018
@zielint0 zielint0 changed the title refactor: move Ifs.java to testclasses in control WIP: refactor: move Ifs.java to testclasses in control Jul 7, 2018
@zielint0 zielint0 changed the title WIP: refactor: move Ifs.java to testclasses in control refactor: move Ifs.java to testclasses in control Jul 7, 2018
@surli
Copy link
Collaborator

surli commented Jul 10, 2018

The changes only shows a move of the file: is it used somewhere?

@zielint0
Copy link
Contributor Author

No. Checked in IDEA IDE (Find Usages) and by name (full text search / grep).

@zielint0
Copy link
Contributor Author

@surli
#2197

@monperrus
Copy link
Collaborator

can we simply remove the file?

@zielint0 zielint0 mentioned this pull request Jul 10, 2018
Open
@zielint0
Copy link
Contributor Author

zielint0 commented Jul 10, 2018 •
edited
Loading

can we simply remove the file?

No references.
All green on Travis.
I suspect it may be removed.

@monperrus monperrus merged commit 9a468b5 into INRIA:master Jul 12, 2018
@zielint0 zielint0 deleted the refactor-move-resources-to-testclasses-in-control branch July 12, 2018 20:05
@monperrus monperrus mentioned this pull request Sep 20, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zielint0 @surli @monperrus