Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Code inspection: String concatenation in loop #2234

Merged
merged 1 commit into from
Jul 17, 2018
Merged

refactor: Code inspection: String concatenation in loop #2234

merged 1 commit into from
Jul 17, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Jul 16, 2018 •
edited
Loading

Performance

  • String concatenation in loop

This is also SonarQube checker (Use a StringBuilder instead.).

Rationale
String concatenation in loop is orders of magnitude slower than StringBuilder.

@zielint0 zielint0 mentioned this pull request Jul 16, 2018
Closed
@surli surli merged commit 39854b1 into INRIA:master Jul 17, 2018
@zielint0 zielint0 deleted the refactor-code-inspection-string-concatenation-in-loop branch July 17, 2018 19:08
@monperrus monperrus mentioned this pull request Sep 20, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zielint0 @surli