Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo: Occurence->Occurrence (important for consistency, see previous changes!) #2249

Merged
merged 5 commits into from
Jul 30, 2018
Merged

fix typo: Occurence->Occurrence (important for consistency, see previous changes!) #2249

merged 5 commits into from
Jul 30, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Jul 18, 2018

@monperrus

This PR is follow up to refactor: fix naming occurences (re-introduced) #2214
As you merged #2214, this one should be too.
This PR finishes partial fix from #2214

Previous discussion: #2206
@pvojtechovsky

... it is interesting how much work might be to fix one missing r ... :-(

It is even more - it looks like I forgot to rename:

  • setMinOccurence method and its argument
  • setMaxOccurence
  • patterns

so I created this PR.

Because we cannot have pair:

  • setMinOccurence (single r)
  • setMaxOccurrence (double r)

this PR is required for consistency and to clean a mess. Sorry!

I think now we have consistent min/max methods & their arguments & correct patterns. Someone please take a look.

I am ready to merge.

@zielint0 zielint0 changed the title fix typo: Occurence->Occurrence fix typo: Occurence->Occurrence (important for consistency, see previous changes!) Jul 21, 2018
@zielint0 zielint0 changed the title fix typo: Occurence->Occurrence (important for consistency, see previous changes!) WIP fix typo: Occurence->Occurrence (important for consistency, see previous changes!) Jul 23, 2018
@zielint0 zielint0 changed the title WIP fix typo: Occurence->Occurrence (important for consistency, see previous changes!) fix typo: Occurence->Occurrence (important for consistency, see previous changes!) Jul 23, 2018
@spoon-bot
Copy link
Collaborator

API changes: 2 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:7.1.0-20180723.155253-56 / New API: fr.inria.gforge.spoon:spoon-core:jar:7.1.0-SNAPSHOT

Method was removed.
Old method PatternParameterConfigurator#setMaxOccurence(int)
New none
Breaking binary: breaking
Method was removed.
Old method PatternParameterConfigurator#setMinOccurence(int)
New none
Breaking binary: breaking

@surli
Copy link
Collaborator

surli commented Jul 30, 2018

It still concerns typo in patterns, @pvojtechovsky are you ok to merge?

@pvojtechovsky
Copy link
Collaborator

I am OK with merge. May be we should release Spoon then again to minimize amount of clients of that old wrong API.

@surli surli merged commit f499611 into INRIA:master Jul 30, 2018
@surli
Copy link
Collaborator

surli commented Jul 30, 2018

May be we should release Spoon then again to minimize amount of clients of that old wrong API.

I might release Spoon at the end of august if needed. Don't hesitate to open an issue if you feel the need.

@zielint0
Copy link
Contributor Author

@surli
@pvojtechovsky
Thank you very much!

@monperrus monperrus mentioned this pull request Sep 20, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants