Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: feat: CompilationUnit extends SourcePositionHolder #2255

Merged
merged 2 commits into from
Jul 22, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

CompilationUnit extends SourcePositionHolder now, so it can act as root of source fragments - as needed for sniper mode pretty printer as discussed in #2254.

@pvojtechovsky pvojtechovsky changed the title feat: CompilationUnit extends SourcePositionHolder review: feat: CompilationUnit extends SourcePositionHolder Jul 21, 2018
@tdurieux
Copy link
Collaborator

Thanks, I will merge when I will be home.

@surli surli merged commit 6deb7e3 into INRIA:master Jul 22, 2018
@pvojtechovsky pvojtechovsky deleted the feaCU_SourcePositionHolder branch July 22, 2018 15:42
@monperrus monperrus mentioned this pull request Oct 10, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants