review: fix(pattern): ForEachNode#replaceNode #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cann't -> Cannot |
pvojtechovsky
force-pushed
the
fixForEachNode
branch
from
75fd007
to
a2b41cf
Compare
pvojtechovsky
changed the title
|
Tomasz pointed at this problem in another PR, so I noticed that there is wrong code here. This PR contains a fix, but I do not know how to test it. The test would have to
|
|
Thank you for deeper inspection than in my PR :) |
pvojtechovsky
force-pushed
the
fixForEachNode
branch
from
a2b41cf
to
80ff885
Compare
|
I'm ok to merge it without a test: but can you at least add some comments on the method to explain that specific situation? |
|
Apparently you broke the checkstyle when pasting the comment I think. Could you fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.