fix: Unreachable code #2488
Merged
fix: Unreachable code #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -691,7 +691,7 @@ private int getEndOfComment(char[] content, int maxOff, int off) { | |||
| if (content[off] == '\r') { | |||
| //we have found end of this comment | |||
| //skip windows \n too if any | |||
| if (content[off] == '\n') { | |||
| if (off < maxOff && content[off + 1] == '\n') { | |||
There was a problem hiding this comment.
Yes, it needs + 1. But also in first part of condition. Like this:
if (off + 1 < maxOff && content[off + 1] == '\n')
OK?
There was a problem hiding this comment.
But why? The maximum value of maxOff is content.length - 1 (see the upper lines), so it seems like a valid bounds check to me.
There was a problem hiding this comment.
You are right! So it is OK. Thank you.
pvojtechovsky
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unreachable code (#2483 Warning 2)
I'm not quite sure what to do with that one, but there is definitely an error here (unreachable code):