fix: comment of CtAnnotation value

[monperrus]

fix #2209

Note that it's a partial fix, the comment should be added to the expression inside the annotation, but it's still much better than the dirty exception in logs of before.

[tdurieux]

It is not a fix, you basically remove the log.

I strongly disagree with this solution.

This log is designed to detect thoses cases.

[monperrus]

It's not only removing the log, the comment is attached to an element, so there is a new best-effort behavior.

Are you against this best-effort behavior?

[tdurieux]

I'm against this one because from my experience the computed parent of comment can be pretty far from an acceptable target.

And also because you removed the only way to detect those buggy case. From my point of view, this log is one of the best logs you can have. When this log is printed it means that there is a bug in the application.
With your changes, you completely remove the ability to detect unhandled cases, and the only argument you used was to make the logs nicer when a bug is present.

The solution is to fix the bug that the log you want to remove detected.

[monperrus]

I see what you mean. I've deleted the best effort idea and restored the log.

I've isolated the problem in a failing test case, could you have a look at it? Thanks!

[monperrus]

@pvojtechovsky could you have a look at this one?

[pvojtechovsky]

ok, I will have a look

[pvojtechovsky]

rebase was needed. I did it

[monperrus]

Many thanks Pavel!

[pvojtechovsky]

You are welcome Martin ;-)