refactor: close resource in ZipFolder.java #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @pvojtechovsky do you merge? |
pvojtechovsky
approved these changes
Oct 8, 2018
| ZipEntry entry; | ||
| while ((entry = zipInput.getNextEntry()) != null) { | ||
| // deflate in buffer | ||
| final int buffer = 2048; | ||
| ByteArrayOutputStream output = new ByteArrayOutputStream(buffer); |
There was a problem hiding this comment.
This code seems to be wrong.
The content of output will grow with each zip entry. Before, it was reset with each entry.
Solution:
A) create ByteArrayOutputStream in scope of while body, similar like before
B) call ByteArrayOutputStream#reset() method to clear it's content
There was a problem hiding this comment.
Thank you Pavel. I felt there is something wrong with it.
There was a problem hiding this comment.
Please consider using IOUtils from Apache.
|
@monperrus please review my changes too and merge it - if ok. Thank you. |
|
Thanks for the added test, a new test is always valuable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure a resource is properly released.
@pvojtechovsky
Pavel could you take a look on public List getFiles() and tell me if this algorithm is correct before and after change.