Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant cast - CtRolePathElement.java #2640

Merged
merged 1 commit into from
Oct 9, 2018
Merged

refactor: remove redundant cast - CtRolePathElement.java #2640

merged 1 commit into from
Oct 9, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Oct 8, 2018

Remove redundant cast from CtElement to CtElement.

Checker: Redundant type cast
Reports unnecessary cast expressions.

This is also SonarQube fix - Remove this unnecessary cast to "CtIf".

@monperrus monperrus merged commit d15ecd3 into INRIA:master Oct 9, 2018
@monperrus
Copy link
Collaborator

@zielint0 could you add a checkstyle rule so that redundant casts now fail the build? Thanks.

@zielint0
Copy link
Contributor Author

zielint0 commented Oct 9, 2018

@zielint0 could you add a checkstyle rule so that redundant casts now fail the build? Thanks.

I briefly checked a list of possible Checkstyle violations and it looks that is it beyond Checkstyle.

I found it using IDEA Code Inspection (Redundant type cast).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants