Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PatternMatcher ignores isImplicit #2726

Merged
merged 4 commits into from
Oct 31, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

The isImplicit attribute is ignored by pattern matcher now. It means that these two lines:

java.lang.String x;
String x;

are same from pattern matcher point of view.

It will be tested by #2683 which correctly sets isImplicit attributes and therefore two lines above has different values. Actually the values are same so it is not easily testable.

@pvojtechovsky
Copy link
Collaborator Author

It ignores difference between implicit and non implicit blocks too. For example

if (x) { 
  dosomething();
}

and

if (x) 
  dosomething();

are same from pattern matcher point of view

@monperrus
Copy link
Collaborator

LGTM.

@monperrus
Copy link
Collaborator

I guess it's important for users. Could you update the documentation to explain this?

@pvojtechovsky
Copy link
Collaborator Author

Documentation was added. Thanks for that idea ... I do not like writing documentation much, but I agree that it is critical to have good documentation. It is not enough to have good code ;-)

@monperrus monperrus merged commit 651cd4f into INRIA:master Oct 31, 2018
@monperrus
Copy link
Collaborator

Thanks!

@pvojtechovsky pvojtechovsky deleted the fixMatcherIgnorImplicit branch November 5, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants