feat: CtScannerListener knows role of scanned element #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
changed the title
monperrus
reviewed
Nov 3, 2018
| /** | ||
| * This method is called after the element and all its children have been visited. | ||
| * This method is NOT called if an exception is thrown in {@link #enter(CtElement)} or during the scanning of the element or any of its children element. | ||
| * This method is NOT called for an element for which {@link #enter(CtElement)} returned {@link ScanningMode#SKIP_ALL}. | ||
| * | ||
| * @param role the {@link CtRole}, which `element` has in it's parent. It is null for the first scanned element |
There was a problem hiding this comment.
Suggested change
| * @param role the {@link CtRole}, which `element` has in it's parent. It is null for the first scanned element | |
| * @param role the {@link CtRole}, which `element` has in its parent. It is null for the first scanned element |
| /** | ||
| * Called before the scanner enters an element | ||
| * | ||
| * @param role the {@link CtRole}, which `element` has in it's parent. It is null for the first scanned element |
There was a problem hiding this comment.
Suggested change
| * @param role the {@link CtRole}, which `element` has in it's parent. It is null for the first scanned element | |
| * @param role the {@link CtRole}, which `element` has in its parent. It is null for the first scanned element |
monperrus
changed the title
|
Thanks Pavel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information about role of the scanned element is now available in
CtScannerListener.It makes algorithms of import validators easier and faster.