refactor: Remove unnecessary unchecked cast in getParent(Class) #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
|
👍 will merge |
monperrus
changed the title
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #1846
I found a completely redundant unchecked cast in a method (
getParent(Class)) where we actually have the runtime type to cast to! UsingClass.cast()is safe, as it actually performs a cast at runtime.It should be noted that in this method it doesn't actually matter, because the unchecked cast is preceded by a call to
Class.isAssignableFrom(), which makes it "safe". But still, I think it's a nicer design to just avoid unchecked casts altogether when possible, because the not every Java developer is intimately familiar with what's safe and not when it comes to casting and type parameters.