-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add submodule policy in CONTRIBUTING.md #4930
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be appropriate to at least mention that we don't publish submodules?
Co-authored-by: Simon Larsén <slarse@slar.se>
agree. merged suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me.
@SirYwell @I-Al-Istannen @MartinWitt anything to add? I think the CONTRIBUTING.md file is pretty important so I don't want to merge without you getting the chance to say your piece.
I thought about adding a hint for jitpack.io, but sadly this is pretty unstable and no one should use this for production code. So lgtm you can merge. |
I have found jitpack to be quite reliable for other projects, but users can probably find something nice on their own here. |
I also think that Jitpack is a little bit beyond the scope of these docs (although I concur with @I-Al-Istannen in that I've found it to be reliable when I've used it). Merging this now so we get it in, we can always update it later! |
Thanks @monperrus |
No description provided.