-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/425 publish dataset and collection #520
Open
ekraffmiller
wants to merge
23
commits into
develop
Choose a base branch
from
feat/425-publish-dataset-and-collection
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
changed the base branch from
develop
to
feat/461-publish-collection
October 10, 2024 03:54
ekraffmiller
added
GREI Re-arch
GREI re-architecture-related
SPA.Q4
Not related to any specific Q4 feature
FY25 Sprint 8
FY25 Sprint 8 (2024-10-09 - 2024-10-23)
Original size: 3
labels
Oct 10, 2024
Hi @ekraffmiller could you update js-dataverse package version with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 8
FY25 Sprint 8 (2024-10-09 - 2024-10-23)
GREI Re-arch
GREI re-architecture-related
Original size: 3
SPA: Dataset page (View)
SPA.Q4
Not related to any specific Q4 feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the Publish Dataset feature where both the dataset and it's parent collection are not published. In this case, the Publish Dataset Modal allows the user to publish both the dataset and collection at the same time.
Note that this feature depends on a js-dataverse PR that is not yet merged: IQSS/dataverse-client-javascript#199. When it is merged, package.json can be updated to use the latest 'alpha' version.
Which issue(s) this PR closes:
Special notes for your reviewer:
I'm using
feat/461-publish-collection
as the base branch because it contains the integration code to call the Publish Collection js-dataverse use case.Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
This is not a change from the JSF, but here is what the JSF modal looks like. 'Unpublished' is the name of the parent collection.
Is there a release notes update needed for this change?:
Additional documentation: