Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added null device #340

Merged
merged 1 commit into from
May 19, 2016
Merged

added null device #340

merged 1 commit into from
May 19, 2016

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented May 19, 2016

circumvents #336 and friends

note that the device is still servicable using e.g. dev.new('filename.png'), as i used the null file as default argument.

@flying-sheep
Copy link
Member Author

flying-sheep commented May 19, 2016

@JanSchulz:

could you test if plot(main = '\u2014')

  1. creates a warning (like the one mentioned at conversion failure #336) and doesn’t create a file without the PR
  2. doesn’t create a warning and doesn’t create a file with the PR

on windows?

on linux it behaves as it should

@flying-sheep
Copy link
Member Author

maybe we can add a unit test for this. ideas?

@jankatins
Copy link
Contributor

If so, we nedd to do it in the python test code...

@flying-sheep flying-sheep merged commit 24e6833 into master May 19, 2016
@flying-sheep flying-sheep deleted the null-device branch May 19, 2016 15:02


init_null_device <- function() {
null_file <- switch(.Platform$OS.type, windows = 'NUL', unix = '/dev/null')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac OS X is included here?

Copy link
Member Author

@flying-sheep flying-sheep May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> help(.Platform)
OS.type: character string, giving the *O*perating *S*ystem (family) of
         the computer.  One of"unix"or"windows".

@jankatins
Copy link
Contributor

init_null_device : null_device: no visible global function definition
  for ‘png’
init_null_device: no visible binding for global variable ‘pdf’
Undefined global functions or variables:
  pdf png
Consider adding
  importFrom("grDevices", "pdf", "png")
to your NAMESPACE file.

jankatins added a commit to jankatins/IRkernel that referenced this pull request May 19, 2016
jankatins added a commit to jankatins/IRkernel that referenced this pull request May 19, 2016
@flying-sheep
Copy link
Member Author

fixed, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants