Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Fix check_ssl_cert #129

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

srvrguy
Copy link
Contributor

@srvrguy srvrguy commented May 17, 2024

The check_ssl_cert command that is included in the image is broken in a few ways:

  • Missing the "file" command, which it relies on
  • Always errors out on default behavior because the OCSP check doesn't work

This PR makes a few small changes that get the command working again:

  • Updates to the most recent version of check_ssl_cert, which brings three years of updates and fixes
  • Installs the file and bc packages required by the default script behavior

Copy link

cla-bot bot commented May 17, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @srvrguy

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@srvrguy
Copy link
Contributor Author

srvrguy commented May 21, 2024

The company where I work has signed the CCLA. How can I clear the error status from this?

@Al2Klimov Al2Klimov requested a review from bobapple May 21, 2024 16:29
@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Jun 18, 2024
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Add missing dependencies required by the check_ssl_cert command. Update command to most recent release version, which fixes problems like OCSP checks.
@srvrguy
Copy link
Contributor Author

srvrguy commented Jun 18, 2024

Thank you for the feedback. I've updated the PR to include the changes.

@Al2Klimov Al2Klimov merged commit 0314017 into Icinga:master Jul 9, 2024
2 checks passed
@srvrguy srvrguy deleted the check_ssl_cert_fixes branch July 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants