Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My list of libtool overrides #529

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TheGreatMcPain
Copy link
Contributor

I upgraded to GCC 10 and did an emerge -ave @world this week.

I also have a bunch of *FLAGS+="-fcommon" entries, but I've excluded them, because I don't know where to put them yet.

@InBetweenNames
Copy link
Owner

I tested this out and it looks like most of these actually work on my system, except for media-gfx/imagemagick. There's a couple I can't test for reasons that are not related to -fno-common. Could you post a build.log of dev-lang/orc failing?

@TheGreatMcPain
Copy link
Contributor Author

Oodly enough dev-lang/orc didn't fail for me, so I've removed it from the list.

@InBetweenNames
Copy link
Owner

Could you supply a build.log from any of the other packages, say dev-util/pkgconf?

@TheGreatMcPain
Copy link
Contributor Author

TheGreatMcPain commented Jun 3, 2020

I'm currently in the process of updating my list and I'm not sure how, but most of them are working again without the override. Might be because I've recently upgraded glibc and binutils to their latest ~amd64 versions.

I'll post some logs if I run into a package that actually fails.

EDIT: All of the packages in my list seem to build just fine without the overrides. I've even going through some of the packages that are already inside ltoworkarounds.conf, and a good amount of them are working without NOCOMMON_OVERRIDE_LIBTOOL=1 as well.

@TheGreatMcPain
Copy link
Contributor Author

I've re-emerged all the packages that have NOCOMMON_LIBTOOL_OVERRIDE=1, and all of them compiled without the override.

@TheGreatMcPain
Copy link
Contributor Author

I downgraded binutils back to 2.33.1-r1, and the errors started to show up again.
I guess NOCOMMON_LIBTOOL_OVERRIDE=1 is not needed for binutils-2.34.

Here's a build.log of dev-lang/orc failing: build.log.gz

@InBetweenNames
Copy link
Owner

Interesting -- I have had sys-devel/binutils-2.34 since May 20th, but still need that workaround for a few packages.

@Titaniumtown
Copy link
Contributor

Titaniumtown commented Sep 3, 2020

This fixed an issue with pkgconf compiling, thanks! This should be merged!

@Titaniumtown
Copy link
Contributor

Will this be merged soon? I see nothing blocking it.

@TheGreatMcPain
Copy link
Contributor Author

I'll probably update this list after re-testing it now that binutils-2.34 is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants