Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar: aligned progress bar height with the figma design #1386

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

akashyeole
Copy link
Member

@akashyeole akashyeole commented Jul 24, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Description
Changed the height of progress bar from 16px to 20px to comply with figma design.

Related Issue
#1384

📦 Published PR as canary version: 24.0.2--canary.1386.daea9b3c0cba8d3478d544fde473e67c3e7beb00.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@24.0.2--canary.1386.daea9b3c0cba8d3478d544fde473e67c3e7beb00.0
# or 
yarn add @infineon/infineon-design-system-stencil@24.0.2--canary.1386.daea9b3c0cba8d3478d544fde473e67c3e7beb00.0

@akashyeole akashyeole added the patch patch version bump label Jul 24, 2024
@akashyeole akashyeole self-assigned this Jul 24, 2024
@akashyeole akashyeole linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jul 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-24 12:28 UTC

Copy link
Contributor

--STORYBOOK-PREVIEW--

@tishoyanchev
Copy link
Contributor

@akashyeole
Can you try to optimize the code?
Eg: label prop is not used. The SCSS is a bit chaotic. The label class is used twice inside the stylesheet, and generally there is no need to set the height of the label.
Also, not sure, but I feel that all these conditions that render the label are not needed, or at least not all of them. Please look into it.

@tishoyanchev tishoyanchev merged commit 72da505 into master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar: update height
2 participants