Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Select: Add select all button #1387

Conversation

pfafffabian-ifx
Copy link
Collaborator

@pfafffabian-ifx pfafffabian-ifx commented Jul 24, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Provide the information we need to review your PR. What problem does the pull request solve? "Bug fix" is not a good description.

Related Issue
If you opened an issue before creating the PR, point to it here.

Context
image
image
image

📦 Published PR as canary version: 24.1.2--canary.1387.796e416217073a07bf70dc560b3c0639f0b3d972.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@24.1.2--canary.1387.796e416217073a07bf70dc560b3c0639f0b3d972.0
# or 
yarn add @infineon/infineon-design-system-stencil@24.1.2--canary.1387.796e416217073a07bf70dc560b3c0639f0b3d972.0

Copy link
Contributor

github-actions bot commented Jul 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-29 12:38 UTC

Copy link
Contributor

--STORYBOOK-PREVIEW--

@pfafffabian-ifx pfafffabian-ifx force-pushed the 1131-multi-select-implement-select-all-feature-and-make-search-bar-removable branch 2 times, most recently from fb87295 to 43738e9 Compare July 24, 2024 08:27
@pfafffabian-ifx
Copy link
Collaborator Author

I'm a bit confused regarding the pipeline. Github actions adds the last two commits, but they seem to result in a build error for the angular preview.
Did I something wrong?

@tishoyanchev
Copy link
Contributor

I'm a bit confused regarding the pipeline. Github actions adds the last two commits, but they seem to result in a build error for the angular preview. Did I something wrong?

It's not something you did. It could be the new library JQ that Verena installed. Git-actions is showing all the commits from all the PRs in every PR. The Angular fail might be a separate issue.

Also, can you please resolve the merge conflicts? @pfafffabian-ifx

@pfafffabian-ifx pfafffabian-ifx force-pushed the 1131-multi-select-implement-select-all-feature-and-make-search-bar-removable branch from 807c2d5 to 44fb912 Compare July 25, 2024 12:43
@pfafffabian-ifx
Copy link
Collaborator Author

@tishoyanchev the conflicts are resolved

@tishoyanchev
Copy link
Contributor

@pfafffabian-ifx
1 - rename search-enabled to show-search
2 - rename select-all-enabled to show-select-all
3 - remove console log

@tishoyanchev tishoyanchev merged commit 9016356 into master Jul 29, 2024
Copy link
Contributor

🚀 PR was released in v24.1.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select: implement "select-all" feature and make search bar removable
2 participants