-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Replace Prop-based "info links" with slottable links #1450
Open
pfafffabian-ifx
wants to merge
17
commits into
master
Choose a base branch
from
1438-footer-replace-prop-based-info-links-with-slottable-links
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhancement: Replace Prop-based "info links" with slottable links #1450
pfafffabian-ifx
wants to merge
17
commits into
master
from
1438-footer-replace-prop-based-info-links-with-slottable-links
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
--STORYBOOK-PREVIEW--
|
pfafffabian-ifx
added
the
enhancement
Adding a new feature or improving existing code
label
Sep 11, 2024
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
from
September 12, 2024 11:54
6d2b246
to
0277106
Compare
|
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
4 times, most recently
from
September 17, 2024 13:56
daf0fae
to
f9f86e6
Compare
|
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
2 times, most recently
from
October 17, 2024 07:34
b05e480
to
fd6d0d3
Compare
…226b7ea0b0e69ed650d118218.0
…43288e6da54eefae703c49538.0
…641ca4a8917ed22d983cd2315.0
…1877462271071be82b6384ba5.0
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
2 times, most recently
from
October 17, 2024 09:18
18203dc
to
40402e5
Compare
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
from
October 17, 2024 09:31
40402e5
to
b52b542
Compare
pfafffabian-ifx
force-pushed
the
1438-footer-replace-prop-based-info-links-with-slottable-links
branch
from
October 17, 2024 11:57
497e784
to
64b956e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Removed the glossary-, imprint-, terms-, and privacyPolicy-props and instead replaced them with a "buttons" slot.
Related Issue
#1438
📦 Published PR as canary version:
26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0
✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0 # or yarn add @infineon/infineon-design-system-stencil@26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0