Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Replace Prop-based "info links" with slottable links #1450

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

pfafffabian-ifx
Copy link
Collaborator

@pfafffabian-ifx pfafffabian-ifx commented Sep 10, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Removed the glossary-, imprint-, terms-, and privacyPolicy-props and instead replaced them with a "buttons" slot.

Related Issue
#1438

📦 Published PR as canary version: 26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0
# or 
yarn add @infineon/infineon-design-system-stencil@26.0.0--canary.1450.0d250b1e534bb8a8744cc8de0a9994244f3f2c2f.0

@pfafffabian-ifx pfafffabian-ifx added the major major version bump label Sep 10, 2024
@pfafffabian-ifx pfafffabian-ifx self-assigned this Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://Infineon.github.io/infineon-design-system-stencil/pr-preview/pr-1450/
on branch gh-pages at 2024-10-17 14:31 UTC

Copy link
Contributor

--STORYBOOK-PREVIEW--

@pfafffabian-ifx pfafffabian-ifx added the enhancement Adding a new feature or improving existing code label Sep 11, 2024
@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch from 6d2b246 to 0277106 Compare September 12, 2024 11:54
@tishoyanchev
Copy link
Contributor

@pfafffabian-ifx

  • resolve merge conflicts
  • remove console logs
  • adjust design to Figma (spacing when different layers are removed/added)

@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch 4 times, most recently from daf0fae to f9f86e6 Compare September 17, 2024 13:56
@tishoyanchev
Copy link
Contributor

@pfafffabian-ifx

  • Resolve deployment check fails
  • remove variant="small" from Storybook snippet.

@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch 2 times, most recently from b05e480 to fd6d0d3 Compare October 17, 2024 07:34
@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch 2 times, most recently from 18203dc to 40402e5 Compare October 17, 2024 09:18
@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch from 40402e5 to b52b542 Compare October 17, 2024 09:31
@pfafffabian-ifx pfafffabian-ifx force-pushed the 1438-footer-replace-prop-based-info-links-with-slottable-links branch from 497e784 to 64b956e Compare October 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding a new feature or improving existing code major major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer: replace Prop-based "info links" with slottable links
2 participants