Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types path incorrect #1467

Closed
wants to merge 1 commit into from
Closed

Conversation

curtdept
Copy link

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Typescript was not correctly resolving types. After investigation, types path is incorrect due to changes with bundle directory structure.

@curtdept
Copy link
Author

@tishoyanchev @verena-ifx

@verena-ifx
Copy link
Contributor

@curtdept Thanks! I will test this, as what solved it for us now, was using vite as a build-tool inside the React app instead of React-scripts.

@tishoyanchev
Copy link
Contributor

Opened a new issue: #1472

@verena-ifx
Copy link
Contributor

@curtdept unfortunately, changing the types path still does not make the react wrappers work when used inside a react app that was created using react-scripts.

@curtdept
Copy link
Author

curtdept commented Sep 19, 2024

@verena-ifx it was working well for me, however, these newest builds are missing the types completely now :| And are complaining of a missing dependency @stencil/react-output-target

This is 25.1.0
image

and this is 24.6.4 (the last good we have been able to use)
image

Freshly made 26 canary (no types)
image

Which is odd because if I build it locally, the stuff is there... this is after
build:components
build:components-react

image

This line in your tsconfig is also preventing you from detecting this error.
"noImplicitAny": false,

Its treating all missing type definitions as an any type and this like says do not enforce the any type rule.
https://www.typescriptlang.org/tsconfig/#noImplicitAny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants