Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: prevent active tab from becoming negative index which causes error in React #1532

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Tabs: prevent active tab from becoming negative index which causes error in React #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa32bef
fix(1468): fix console error in tab component and refactor react code…
akashyeole Oct 9, 2024
3f4e378
Merge fa32befff5542e9297ce1eac4ef7c32bc6806f8b into 377cab3c186a64553…
akashyeole Oct 9, 2024
688b63b
Update Stencil library version to 25.7.1--canary.1532.3f4e3786638a39b…
invalid-email-address Oct 9, 2024
965c63a
fix(1468): set first tab to active when activeTabIndex is negative
akashyeole Oct 9, 2024
973c0cf
Merge 965c63afc9b4d653a4b27de509f4bb0f2e37e913 into 377cab3c186a64553…
akashyeole Oct 9, 2024
3a52d05
Update Stencil library version to 25.7.1--canary.1532.973c0cf5060dd8d…
invalid-email-address Oct 9, 2024
f65aa82
fix(1468): merge master branch
akashyeole Oct 9, 2024
ad21b50
Merge f65aa825e71bf4f1be400fd95eb77e4dcafee29c into 5661e454ba411771d…
akashyeole Oct 9, 2024
760f8b1
Update Stencil library version to 25.7.2--canary.1532.ad21b50ecfebca9…
invalid-email-address Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/wrapper-components/react-vite-js/src/components/Tabs/Tabs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { useRef, useEffect } from 'react';
import { useState, useEffect } from 'react';
import { IfxTabs, IfxTab } from '@infineon/infineon-design-system-react';

function Tabs() {

const tabIndex = useRef(0);
const [tabIndex, setTabIndex]= useState(0);
const INTERVAL = 20000;

useEffect(() => {
Expand All @@ -22,7 +22,7 @@ function Tabs() {
const setTab = () => {
const next = Math.floor(Math.random() * (3));
console.log("set next active tab: ", next)
tabIndex.current = next;
setTabIndex(next);
}

return (
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"command": {
"publish": {
"verifyAccess": false
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/components-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "components-angular",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
Expand All @@ -26,7 +26,7 @@
"@angular/platform-browser": "^18.0.0",
"@angular/platform-browser-dynamic": "^18.0.0",
"@angular/router": "^18.0.0",
"@infineon/infineon-design-system-angular": "^25.7.1",
"@infineon/infineon-design-system-angular": "^25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"typescript": "~5.4.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/components-angular/projects/component-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-angular",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"description": "Infineon design system Stencil web components for Angular",
"author": "Verena Lechner",
"license": "MIT",
Expand All @@ -11,7 +11,7 @@
"@angular/common": "^18.0.0",
"@angular/core": "^18.0.0",
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.7.1"
"@infineon/infineon-design-system-stencil": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/components-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-react",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"description": "Infineon design system Stencil web components for React",
"main": "./dist/index.js",
"types": "./dist/types/index.d.ts",
Expand Down Expand Up @@ -28,7 +28,7 @@
},
"dependencies": {
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.7.1"
"@infineon/infineon-design-system-stencil": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0"
},
"auto": {
"plugins": [
Expand Down
4 changes: 2 additions & 2 deletions packages/components-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-vue",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"description": "Infineon design system Stencil web components for Vue",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down Expand Up @@ -31,7 +31,7 @@
},
"dependencies": {
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.7.1"
"@infineon/infineon-design-system-stencil": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0"
},
"auto": {
"plugins": [
Expand Down
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-stencil",
"version": "25.7.1",
"version": "25.7.2--canary.1532.ad21b50ecfebca94216b0eb139834e81320e97d5.0",
"private": false,
"description": "Infineon design system Stencil web components",
"homepage": "https://infineon.github.io/infineon-design-system-stencil",
Expand Down
5 changes: 4 additions & 1 deletion packages/components/src/components/tabs/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export class IfxTabs {
if (index >= this.tabObjects.length) {
index = this.tabObjects.length - 1;
}
if (!this.tabObjects[index].disabled) {
if (index < 0) {
index = 0;
}
if (!this.tabObjects[index]?.disabled) {
this.internalActiveTabIndex = index;
this.internalFocusedTabIndex = index;
}
Expand Down
Loading