Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle clicking links in a private tab opens a normal tab #152

Closed
rolandixor opened this issue Jun 27, 2014 · 5 comments
Closed

Middle clicking links in a private tab opens a normal tab #152

rolandixor opened this issue Jun 27, 2014 · 5 comments
Labels
bug compatibility fixed?

Comments

@rolandixor
Copy link

If you use a Private Tab to open a link in a new tab using middle clicking, it opens the link as a normal (non-private) tab. This only started happening in the latest nightly builds (of Firefox).

Using the menu still works fine.
@judilsteve
Copy link

I am experiencing this issue also. Nightly on Win7 SP1 64-bit (32-bit Nightly build though).

@Infocatcher
Copy link
Owner

This caused by fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1017156
http://hg.mozilla.org/mozilla-central/rev/c8e3aff6a401
All tabs now wrongly detected as empty.

So, as a temporary workaround may be used extensions.privateTab.makeNewEmptyTabsPrivate = -1

Infocatcher added a commit that referenced this issue Jun 28, 2014
@Infocatcher
Correctly detect tabs without labes as not empty (Firefox 33+)
db9d582 
(#152)
Infocatcher added a commit that referenced this issue Jun 28, 2014
@Infocatcher
Update changelog: #152
8282ed9
@Infocatcher
Copy link
Owner

Corrected, test version: private_tab-0.1.7.3pre2-fx-sm.xpi (source).

@judilsteve
Copy link

Seems to be working, cheers.

@rolandixor
Copy link
Author

I only just noticed the fix.

It's working for me.

Infocatcher added a commit that referenced this issue Aug 9, 2014
@Infocatcher
Correct changelog for #152: Firefox 34 still have that changes
40209fc
Infocatcher added a commit that referenced this issue Jan 13, 2015
@Infocatcher
Detect tab without label as empty (remove fix for #152)
e886297 
Also our previous fix for Fast Dial isn't needed…
Looks like label for empty tab was corrected in release version, tested with: Firefox 33.0.3, 33.1.1, 34.0.5, 38.0a1 (2015-01-13)
Infocatcher added a commit that referenced this issue Jan 13, 2015
@Infocatcher
Add note about empty labels on new tabs (#152)
766f356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility fixed?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rolandixor @Infocatcher @judilsteve