Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Tab share same cookies as a normal tab #206

Closed
sylveon opened this issue Jan 30, 2016 · 5 comments
Closed

Private Tab share same cookies as a normal tab #206

sylveon opened this issue Jan 30, 2016 · 5 comments

Comments

@sylveon
Copy link
Contributor

sylveon commented Jan 30, 2016

Title says it alls. On latest Firefox Nightly with Private Tabs v 0.1.9.1pre and e10s enabled.

Video

Other little notes I gathered when using the addon:

  • The private tab marker (Little white mask on violet background near the X) is still visible when I switch to the normal tab.
  • I can see the new private tab button in a private browsing session.
  • When I came back to the window I was for filling the issue, I had to relogin.
  • The tooltip I see when overing the Windows Explorer function isn't localised:
    sans titre
@Infocatcher
Copy link
Owner

Tab wasn't actually private, that was fixed, see: #202.
Bug about indication should be already fixed too.

About localization. French locale isn't complete unfortunately, see
https://github.com/Infocatcher/Private_Tab/blob/master/locale/fr/pt.properties (permanent link to latest version)
https://github.com/Infocatcher/Private_Tab/blob/e4442e051e8e912c60706d8d0375adecf54e1901/locale/fr/pt.properties (current version)

Test version: private_tab-0.1.9.1pre3-fx-sm.xpi (source code).

(Anyway, looks like multi-process things was updated in latest Nightly and at least inheritance mechanism is broken again)

@sylveon
Copy link
Contributor Author

sylveon commented Jan 30, 2016

0.1.9.1pre3 works. (after a restart)
Firefox Nightly breaks a lot of things.
One day, Stylish stopped working (noooooooo). Two weeks later: magic, it restarted working, without intervention from the maker...
I think we should wait 'til developper edition gets updated and update the addon for it, because Firefox Nightly's APIs can change one day, and revert back the other day. It's not enough stable.

@sylveon
Copy link
Contributor Author

sylveon commented Jan 30, 2016

With 0.1.9.1pre3, the private tab is really private, but I still get the indicator visible until I open a new normal tab.
I don't know why, but the "(Private Browsing)" in the title transferred into all the tabs from the same window and later disappeared. Unable to reproduce after that.

@Infocatcher
Copy link
Owner

Now should be fixed in Firefox 45-46. And for 47+: #208.
https://addons.mozilla.org/addon/private-tab/versions/0.1.9.1

@sylveon
Copy link
Contributor Author

sylveon commented Feb 3, 2016

Fixed

@sylveon sylveon closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants