Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e10s] Links loaded from private about:newtab page becomes non-private in Firefox 45+ #202

Closed
ghost opened this issue Dec 27, 2015 · 2 comments
Closed

[e10s] Links loaded from private about:newtab page becomes non-private in Firefox 45+ #202

ghost opened this issue Dec 27, 2015 · 2 comments
Labels
bug compatibility

Comments

@ghost
Copy link

ghost commented Dec 27, 2015

I really like this add-on but it seems does not work on Firefox developer edition.

Cookies from normal tab still exists when i open a private tab.
@Infocatcher
Copy link
Owner

Most likely this is due to enabled multi-process mode (Options – General – Enable multi-process …).
Looks like something is broken now and "private" flag will be removed from pages like about:newtab.
So, it's still possible to open about:newtab in private tab, but something went wrong, if you try to load some http… page in that tab.

@Infocatcher Infocatcher changed the title Does not work on Firefox Developer Edition 45 [e10s] Links loaded from private about:newtab page becomes non-private in Firefox 45+ Jan 26, 2016
Infocatcher added a commit that referenced this issue Jan 26, 2016
@Infocatcher
Force make tab private, if their remotness was changed
4015123 
(#202)
Infocatcher added a commit that referenced this issue Jan 26, 2016
@Infocatcher
Listen for "TabRemotenessChange" only in multi-process mode
661acea 
(#202)
Infocatcher added a commit that referenced this issue Jan 26, 2016
@Infocatcher
Update changelog:
37b2dd3 
* #202 (broken new private tab in e10s mode)
* private mode indication (e10s)
Infocatcher added a commit that referenced this issue Jan 27, 2016
@Infocatcher
Handle tab remotness changes for non-private tabs in private windows
83afde2 
(#202)
@Infocatcher Infocatcher mentioned this issue Jan 30, 2016
Closed
@ghost
Copy link
Author

ghost commented Feb 2, 2016

Thanks for your fixes @Infocatcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher