Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: New tab opens in wrong window [MacOS] #23

Closed
asleepysamurai opened this issue Mar 28, 2020 · 0 comments
Closed

Bug: New tab opens in wrong window [MacOS] #23

asleepysamurai opened this issue Mar 28, 2020 · 0 comments
Labels
bug compatibility

Comments

@asleepysamurai
Copy link
Contributor

asleepysamurai commented Mar 28, 2020 •
edited
Loading

I think this is a Mac OS specific issue, since in Linux and Windows, right-clicking on a window automatically makes it the active focused window, which is not the case in MacOS.

Steps to reproduce:

  1. Open any page in Firefox.
  2. Open a new window. Resize the new window so that atleast 1 link on the old window is visible.
  3. Click anywhere (not on a link) within the new window to make it the active focused window.
  4. Right click on any link in the old window (without clicking anything else on the old window).
  5. The new tab opens in the new window instead of the old window.

This is especially annoying on multi monitor setups where the active window is on a different monitor to the one window where the link was clicked on.

I would be happy to contribute a fix. I do not yet know if a fix is actually possible, have to read up on Firefox WE APIs.

Edit: Appears to be a simple fix. Have submitted a PR.
asleepysamurai added a commit to asleepysamurai/Right_Links_WE that referenced this issue Mar 28, 2020
@asleepysamurai
Bugfix Infocatcher#23 New tab opening in incorrect window in MacOS
48b793f
@asleepysamurai asleepysamurai mentioned this issue Mar 28, 2020
Merged
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Merge pull request #24 from asleepysamurai/master
ba5a4b4 
Bugfix #23 New tab opening in incorrect window in MacOS
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Update changelog:
800b5a3 
* open link in discarded (unloaded) tab (#22)
* correctly open tabs from non-focused window in MacOS (#23)
Infocatcher added a commit that referenced this issue Mar 8, 2021
@Infocatcher
Specify .windowId only in MacOS
952144b 
(#23, #24)

STR:
1. Open popup window, example HTML page:
<a href="javascript: window.open(location.href, '', 'width=300,height=300'); void 0;">Open popup window</a>
2. Right-click on any link in popup window: should be used last active non-popup window (like for built-in browser actions)

Also
browser.windows.getAll({ windowTypes: ["normal"] })
is useless… :(
Infocatcher added a commit that referenced this issue Mar 8, 2021
@Infocatcher
Optimize: call browser.runtime.getPlatformInfo() only once
14ab641 
(#23, #24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asleepysamurai @Infocatcher