Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scope] add scope for ClassDef.name node #349

Merged
merged 1 commit into from
Jul 24, 2020
Merged

[scope] add scope for ClassDef.name node #349

merged 1 commit into from
Jul 24, 2020

Conversation

jimmylai
Copy link
Contributor

Summary

Issue was reported in #329, FunctionDef.name has scope object associated but ClassDef.name doesn't.
This PR fixes the inconsistency.

Test Plan

Updated unit tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2020
zsol
zsol approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@jimmylai jimmylai merged commit 0870e41 into Instagram:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

@luciawlli luciawlli Awaiting requested review from luciawlli

@josieesh josieesh Awaiting requested review from josieesh

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmylai @zsol @facebook-github-bot