Consider access information when computing qualified names for nodes #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scope.get_qualified_names_for
has to do a lot of work to determine the qualified name for a node. The current version does not consider the data we have for accesses. If the given node is known to be an access, we can take advantage of that to work out the proper name.This also means we now get the qualified names for string annotations for imports.
Test Plan
I've added a new test case in the QualifiedNameProviderTest to show the before/after effects of this change