Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the 0.4.1 behavior for libcst.helpers.get_absolute_module #684

Merged
merged 1 commit into from
May 11, 2022

Conversation

lpetre
Copy link
Contributor

@lpetre lpetre commented May 11, 2022

Summary

I silently changed how this function behaved in #660

Anyone using this API and updating to 0.4.2 would experience different (and broken) behavior.

Test Plan

(libcstvenv) lpetre@lpetre-mbp LibCST % python -m unittest libcst.helpers.tests.test_module          
...............................................
----------------------------------------------------------------------
Ran 47 tests in 0.037s

OK

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #684 (4f0d974) into main (460698a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   94.81%   94.82%           
=======================================
  Files         246      246           
  Lines       25621    25653   +32     
=======================================
+ Hits        24293    24325   +32     
  Misses       1328     1328           
Impacted Files Coverage Δ
libcst/helpers/__init__.py 100.00% <ø> (ø)
libcst/codemod/commands/remove_unused_imports.py 95.12% <100.00%> (ø)
libcst/codemod/visitors/_add_imports.py 95.45% <100.00%> (ø)
libcst/codemod/visitors/_gather_imports.py 96.15% <100.00%> (ø)
libcst/codemod/visitors/_imports.py 96.42% <100.00%> (ø)
libcst/codemod/visitors/_remove_imports.py 93.52% <100.00%> (ø)
libcst/helpers/module.py 100.00% <100.00%> (ø)
libcst/helpers/tests/test_module.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460698a...4f0d974. Read the comment docs.

Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants