Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix pypi_upload workflow #889

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[ci] Fix pypi_upload workflow #889

merged 1 commit into from
Mar 9, 2023

Conversation

zsol
Copy link
Member

@zsol zsol commented Mar 8, 2023

[ci] Fix pypi_upload workflow
pypi_upload has been broken since #810, because actions/checkout defaults to a shallow checkout that only checks out the revision triggering the workflow. This causes setuptools-scm to miss the most recent tag, causing the version to be detected as 0.1.


Stack created with Sapling. Best reviewed with ReviewStack.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2023
@zsol zsol marked this pull request as ready for review March 8, 2023 14:22
@zsol zsol requested a review from amyreese March 8, 2023 14:22
Copy link
Member

@amyreese amyreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pypi_upload has been broken since #810, because `actions/checkout` defaults to a shallow checkout that only checks out the revision triggering the workflow. This causes setuptools-scm to miss the most recent tag, causing the version to be detected as `0.1`.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ccba6b) 94.87% compared to head (1995e70) 94.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files         249      249           
  Lines       25819    25819           
=======================================
  Hits        24495    24495           
  Misses       1324     1324           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zsol zsol merged commit 577e5d5 into main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants