Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update cache-max-entry-count help message #1892

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

zhyncs
Copy link
Collaborator

@zhyncs zhyncs commented Jul 1, 2024

Motivation

as titled cc @lvhan028 @AllentDan

Modification

as titled

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@AllentDan AllentDan added the documentation Improvements or additions to documentation label Jul 1, 2024
@lvhan028 lvhan028 added improvement and removed documentation Improvements or additions to documentation labels Jul 1, 2024
@lvhan028 lvhan028 merged commit 5ceb464 into InternLM:main Jul 1, 2024
4 of 5 checks passed
@zhyncs zhyncs deleted the update-doc branch July 1, 2024 06:28
@zhyncs
Copy link
Collaborator Author

zhyncs commented Jul 1, 2024

Sorry for introducing the lint failure with flake8

@zhyncs
Copy link
Collaborator Author

zhyncs commented Jul 1, 2024

@ lmdeploy/cli/utils.py:382 @ class ArgumentHelper:
            '--cache-max-entry-count',
            type=float,
            default=0.8,
-           help=
-           'The percentage of free gpu memory occupied by the k/v cache, excluding weights'
+           help=\
+          'The percentage of free gpu memory occupied by the k/v cache, excluding weights' # noqa
        )

Hi @AllentDan May you help update this? Thanks.

@lvhan028
Copy link
Collaborator

lvhan028 commented Jul 1, 2024

I am going to fix it in #1852

@zhyncs
Copy link
Collaborator Author

zhyncs commented Jul 1, 2024

I am going to fix it in #1852

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants