Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Added a bash version verification #26

Merged
merged 1 commit into from
May 5, 2017
Merged

Conversation

n0tnull
Copy link
Contributor

@n0tnull n0tnull commented May 5, 2017

It will be more obvious for someone to know if their bash version is not capable of running this script.

@IzzySoft IzzySoft merged commit ba8950d into IzzySoft:master May 5, 2017
@IzzySoft
Copy link
Owner

IzzySoft commented May 5, 2017

Thanks a lot, great idea! Let me just improve a minor thing: If there's no Bash, $BASH_VERSION will not be set. So I just changed that to ${BASH_VERSION:-(unknown)} for a clean error message. Though due to the #!/usr/bin/env bash it should never come to that 😸

@n0tnull
Copy link
Contributor Author

n0tnull commented May 5, 2017

That's right, I forgot to handle this error case, it's better now 👍
Can you update the wiki with the new exit code too ?

EDIT: There's no way for me to do a PR on the Wiki, so you can find the updated version here : https://github.com/n0tnull/Adebar/wiki/_compare/d69a3b4e120c2d24c7ce7d3aae4cf5207abd70fe

@IzzySoft
Copy link
Owner

IzzySoft commented May 6, 2017

Done, thanks! Yes, I also encountered that unfortunate restriction. But the only alternative doesn't work out either (having the Wiki publically editable). Which is why e.g. #7 is still open (and will remain open), so people can add device configurations there and I transfer it to the wiki.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants