Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): Changing hwo the gcs client is generated #28

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

Jacobbrewer1
Copy link
Owner

Describe your changes

Passing the client back rather than setting a global variable.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • For new code, I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have implemented monitoring for my changes if applicable.

@Jacobbrewer1 Jacobbrewer1 merged commit e9f5379 into main Mar 29, 2024
6 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the gcs-flow branch March 29, 2024 07:59
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant