fix: correctly consume the child block, with example fenced code block #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarlovi
commented
Jan 9, 2024
dkarlovi
commented
Jan 9, 2024
|
See thephpleague/commonmark#1008, this now works as expected, ready for review. |
dkarlovi
changed the title
JanStanleyWatt
approved these changes
Jan 10, 2024
|
Thanks all for your contrebute! |
|
Thank you for the review and working on this project @JanStanleyWatt, looking forward to seeing this bugfix released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlights the issue with the extensions where it will eat all the spaces from a nested code block. I'm not sure if it's due to the extension or a bug upstream.