Fix toString as '[Object object]' in a vm #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #255, thanks to @markdalgleish for the base code.
This pull request shortcuts the
toString.toString()
workaround by ensuring it fails the existingarg.toString !== Object.prototype.toString
first.Seeing as
toString
is an edge case in the first place, this balances our performance by having low to no impact in typical usage.We have the option to shortcut with
hasOwnProperty('toString')
if that code path is desired, but I have opted out of that for now.Benchmark results for this pull request